Skip to content

Fix archive error when rename repo or user #16399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 13, 2021
Merged

Fix archive error when rename repo or user #16399

merged 4 commits into from
Jul 13, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Jul 11, 2021

Fix #16390

#14723 introduced two bugs, one is to delete all archivers may failed, another is after rename repo or user, visit archivers may failed.

This PR will fix them. But it's a break change. After applying the patch, please run Delete all repositories' archives to remove all old files which may become garbages.

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2021 •
edited
Loading

Codecov Report

Merging #16399 (dc7a308) into main (b81106b) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16399      +/-   ##
==========================================
+ Coverage   45.46%   45.47%   +0.01%     
==========================================
  Files         711      712       +1     
  Lines       83956    83953       -3     
==========================================
+ Hits        38168    38180      +12     
+ Misses      39642    39626      -16     
- Partials     6146     6147       +1
Impacted Files Coverage Δ
models/repo.go 54.66% <ø> (+0.52%) ⬆️
models/repo_archiver.go 0.00% <0.00%> (ø)
modules/cron/tasks_extended.go 69.44% <0.00%> (ø)
modules/repository/archive.go 0.00% <0.00%> (ø)
modules/storage/storage.go 49.27% <0.00%> (-3.04%) ⬇️
modules/charset/charset.go 71.71% <0.00%> (-4.05%) ⬇️
services/pull/pull.go 42.36% <0.00%> (+0.43%) ⬆️
modules/git/blame.go 67.14% <0.00%> (+1.42%) ⬆️
modules/notification/mail/mail.go 38.23% <0.00%> (+1.96%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b81106b...dc7a308. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 11, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 11, 2021
@6543 6543 added this to the 1.15.0 milestone Jul 11, 2021
zeripath
zeripath reviewed Jul 12, 2021
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 13, 2021
@6543 6543 merged commit 67f135c into go-gitea:main Jul 13, 2021
@lunny lunny deleted the lunny/fix_archive branch July 13, 2021 14:53
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@lunny @AbdulrhmnGhanem
Fix archive error when rename repo or user (go-gitea#16399)
e4d3fd2 
Use repo id instead of full name to generate archive path
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

+2 more reviewers

@zeripath zeripath zeripath left review comments

@noerw noerw noerw approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

Repo Archive path invalid after rename
6 participants
@lunny @codecov-commenter @zeripath @noerw @6543 @GiteaBot